Nginx: Fix Strict-Transport and X-Frame-Options#112
Closed
MiguelNdeCarvalho wants to merge 1 commit intolinuxserver:masterfrom
MiguelNdeCarvalho:patch-1
Closed
Nginx: Fix Strict-Transport and X-Frame-Options#112MiguelNdeCarvalho wants to merge 1 commit intolinuxserver:masterfrom MiguelNdeCarvalho:patch-1
MiguelNdeCarvalho wants to merge 1 commit intolinuxserver:masterfrom
MiguelNdeCarvalho:patch-1
Conversation
Errors:
The "X-Frame-Options" HTTP header is not set to "SAMEORIGIN". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly.
The "Strict-Transport-Security" HTTP header is not set to at least "15552000" seconds. For enhanced security, it is recommended to enable HSTS as described in the security tips ↗.
Collaborator
aptalca
requested changes
Oct 7, 2019
Member
aptalca
left a comment
aptalca
left a comment
There was a problem hiding this comment.
HSTS should be handled at the reverse proxy level, or be manually added by the user
Contributor
Author
|
So I should do this pr on |
Member
|
No, HSTS is already an option there in ssl.conf |
|
Related to #119 With the changes to Nextcloud 17, shouldn't we be including: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors:
The "X-Frame-Options" HTTP header is not set to "SAMEORIGIN". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly.
The "Strict-Transport-Security" HTTP header is not set to at least "15552000" seconds. For enhanced security, it is recommended to enable HSTS as described in the security tips ↗.
Thanks, team linuxserver.io